Opened on 09/14/2017 at 11:51:23 AM

#5677 new change

Update punycode.js

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



It has been already done in adblockpluschrome, #4350, and it would be useful to do it in libadblockplus as well.

What to change

  • For the sake of simplicity copy punycode.js from adblockpluschrome repository
  • add support of module in
  • put punycode.js at the beginning of library_files list in libadblockplus.gyp because now it supports require mechanism.
  • change how it's used in lib/basedomain.js
  • add tests verifying that the new version still works
  • whatever else is required

Attachments (0)

Change History (0)

Add Comment

Modify Ticket

Change Properties
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Note: See TracTickets for help on using tickets.