Opened 2 years ago

Closed 2 years ago

#5683 closed defect (fixed)

Make og:url(s) locale specific

Reported by: juliandoucette Assignee: juliandoucette
Priority: P2 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: saroyanm, greiner, kvas, jsonesen, wspee, ire, paco, ferris Blocked By:
Blocking: #1274 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29588973,
https://codereview.adblockplus.org/29588976/

Description (last modified by juliandoucette)

Environment

All websites shares on Facebook.

How to reproduce

Share a non-English page URL on Facebook. Repeat the same test after changing your browser, system, and Facebook locale appropriately.

Observed behavior

  • The Facebook website preview is always in English (See Facebook bug)
  • The Facebook website share is English most of the time
    • I resolved #5447, #5402, #5392, #1274 after repeating the "steps to reproduce" above with Ferris and seeing the "expected behavior" below
      • Unfortunately, I have tested this again after re-landing #5447 and my tests did not pass
      • I suspect that this is a cache and/or Facebook issue
      • See Facebook bug

Expected behavior

Facebook should scrape each og:locale:alternate and show each locale appropriately (according to your Facebook locale).

Suggested fix

Add locale to og:url(s).

I think this contradicts ogp.me's definition of og:url as a "canonical" link. But I see no alternative at this point. We need a reliable way to share non-English website pages on Facebook to resolve #1274. The implications of this fix are {1: Shares for individual pages may be counted separately per locale, 2: Shares will not be translated on Facebook according to the user's Facebook locale (instead, they will appear in the locale specified in the shared URL e.g. /en/page, /de/page)}

Change History (13)

comment:1 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:2 Changed 2 years ago by juliandoucette

@wspee I believe that we have implemented og:url, og:locale, og:locale:alternate, and fb_locale correctly according to all available documentation. But it wouldn't hurt to have QA test this issue before I give up and UN-canonicalize our og:url(s). Can you organize this?

comment:4 Changed 2 years ago by juliandoucette

  • Blocking 1274 added

comment:5 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:6 Changed 2 years ago by juliandoucette

  • Cc paco ferris added

comment:7 Changed 2 years ago by rraceanu

Issue still occurs, verified multiple OS's / browsers.

comment:8 Changed 2 years ago by juliandoucette

  • Ready set

comment:9 Changed 2 years ago by juliandoucette

  • Owner set to juliandoucette

comment:10 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5683 - Made og:url locale specific

comment:12 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5683 - Made og:url locale specific

comment:13 Changed 2 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.