Opened 2 years ago

Closed 21 months ago

#5689 closed change (fixed)

Add rules for CSS declaration order to stylelint-config-eyeo

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: saroyanm, greiner, martin, p.pastourmatzis, erick, fhd, juliandoucette Blocked By: #5109
Blocking: #6288 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29643562/

Description

Background

Our Coding Style states that "CSS rule declaration order should follow the WordPress CSS Coding Standards".

What to change

In #5109 we are creating a stylelint configuration for eyeo but the default stylelint rules no longer include declaration order.

Use a stylelint plugin (such as stylelint-order) to set a declaration order to our stylelint-config

Change History (7)

comment:1 Changed 2 years ago by ire

  • Cc juliandoucette added

comment:2 Changed 23 months ago by juliandoucette

  • Component changed from Websites to Automation
  • Keywords goodfirstbug added

comment:3 Changed 22 months ago by ire

  • Owner set to ire
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 22 months ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 21 months ago by kzar

  • Blocking 6288 added

comment:6 Changed 21 months ago by abpbot

comment:7 Changed 21 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.