Opened 5 years ago

Last modified 21 months ago

#569 new defect

Truncated elemhide filters in report colored as blocked resources

Reported by: famlam Assignee:
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Mozilla Firefox 29.0.1, Gecko 29.0.1 build 20140506152807
ABP 2.6.1.3824, nl

How to reproduce

  1. Submit a report of a page with a long elemhide filter (example: https://reports.adblockplus.org/9ad344d4-fca0-4187-bf06-77bf52476190#tab=requests for page nl.msn.com )
  2. Notice that (in the Requests tab) the color of the truncated filter 1025thebull.com,1031iheartaustin.com,1031thevulcan.com,1037theq.com,1041beat.com,1043hallelujahfm.com,1055online.com,1061fmtalk.com,1067litefm.com,247comedy.com,850koa.com,940winz.com,94hjy.com,970espn.com,99kisscountry.com,afro.com,allmusic.com,am1300thezone.com,am570radio.com,am760.net,amctv.com,app.com,araratadvertiser.com.au,areanews.com.au,argusleader.com,armidaleexpress.com.au,avclub.com,avonadvocate.com.au,barossaherald.com.au,batemansbaypost.com.au,battlecreekenquirer.com,baxterbulletin.com,baysidebulletin.com.au,begadistrictnews.com.au,bellingencourier.com.au,bendigoadvertiser.com.au,benningtonbanner.com,big1059.com,bigthink.com,bizarremag.com,blacktownsun.com.au,blayneychronicle.com.au,bluemountainsgazette.com.au,bombalatimes.com.au,boorowanewsonline.com.au,bordermail.com.au,braidwoodtimes.com.au,brimbankweekly.com.au,bucyrustelegraphforum.com,bunburymail.com.au,burlingtonfreepress.com,businessinsurance.com,busseltonmail.com.au,camdenadvertiser.com.au,camdencourier.com.au,canowindranews.com.au,capit… is not the color of an elemhide filter, but of a blocked filter, although the third column confirms it really is an elemhide filter

Observed behaviour

Wrong color (#FFC0C0) of the row with the elemhide filter

Expected behaviour

Correct color (#C0C0FF) of the row with the elemhide filter

Suggested fix

Change:

file: sitescripts/reports/template/report.html
{%- elif request.filter and request.filter.count('#') %} class="hidden"

into:

file: sitescripts/reports/template/report.html
{%- elif request.filter and request.type.lower() == 'elemhide' %} class="hidden"

(untested)

Change History (3)

comment:1 Changed 5 years ago by philll

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 years ago by philll

  • Platform set to Firefox

comment:3 Changed 21 months ago by sebastian

  • Component changed from Unknown to Sitescripts
  • Platform changed from Firefox to Unknown / Cross platform
  • Priority changed from P3 to P4
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.