Opened 2 years ago

Closed 2 years ago

#5701 closed defect (fixed)

Inconsistent forum link on new options page and missing DNT link

Reported by: sebastian Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: wspee, greiner, saroyanm Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29555782/

Description (last modified by saroyanm)

How to reproduce

  1. Run ./test_server.py from inside the adblockplusuirepository.
  2. Go to http://localhost:5000/new-options.html?platform=chromium#help
  3. Click "Go to Forum" link.
  4. Observe
  5. Go to http://localhost:5000/new-options.html#general
  6. Click on "Allow only nonintrusive ads that are privacy-friendly"
  7. Click on "Find out how to turn on DNT"
  8. Observe

Observed behaviour

Expected behaviour

  • Step 4: The "Go to Forum" link should link to https://adblockplus.org/redirect?link=<application>_support&lang=<lang>, where <application> is the application from the info module, except info.platform == "chromium" && info.application != "opera" in which case it should be chrome (as we don't have separate sub-forums for all Chromium forks). See here. logic of the old options page.
  • Step 8: Find out how to turn on DNT should behave as specified here

Change History (9)

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)

I assume you mean the link in Help tab as I can't find one in the advanced tab.

@wspee do you remember if there was a reason why we decided to redirect to redirect to the forum, but not to the platform specific sub page ? If not, please let me know if you want me to create a bitbucket issue for this.

comment:2 Changed 2 years ago by wspee

@saroyanm
I think it was an oversight, see #78.

comment:3 Changed 2 years ago by saroyanm

  • Blocking 5158 added
  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Priority changed from P2 to P1
  • Summary changed from Inconsistent forum link on new options page to Inconsistent forum link on new options page and missing DNT link

DNT link should behave similarly so I merged both issues, to tackle them here.

comment:5 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:6 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:7 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5701 - fixed inconsistent forum links and missing DNT link

comment:9 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.