Changes between Version 1 and Version 4 of Ticket #5701


Ignore:
Timestamp:
09/25/2017 03:41:11 PM (3 years ago)
Author:
saroyanm
Comment:

DNT link should behave similarly so I merged both issues, to tackle them here.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5701

    • Property Priority changed from Unknown to P1
    • Property Ready set
    • Property Summary changed from Inconsistent forum link on new options page to Inconsistent forum link on new options page and missing DNT link
    • Property Blocking changed from to 5158
  • Ticket #5701 – Description

    v1 v4  
    332. Go to http://localhost:5000/new-options.html?platform=chromium#help 
    443. Click "Go to Forum" link. 
     54. Observe 
     65. Go to http://localhost:5000/new-options.html#general 
     76. Click on "Allow only nonintrusive ads that are privacy-friendly" 
     87. Click on "Find out how to turn on DNT" 
     98. Observe 
    510 
    611=== Observed behaviour === 
    7 It opens https://adblockplus.org/redirect?link=reporter_other_link in a new tab which redirects to https://adblockplus.org/forum/. That is a step back from the old options page which linked to the corresponding sub-forum. 
     12* It opens https://adblockplus.org/redirect?link=reporter_other_link in a new tab which redirects to https://adblockplus.org/forum/. That is a step back from the old options page which linked to the corresponding sub-forum.  
     13* Find out how to turn on DNT link is missing  
    814 
    915=== Expected behaviour === 
    10 The "Go to Forum" link should link to `https://adblockplus.org/redirect?link=<application>_support&lang=<lang>`, where `<application>` is the `application` from the `info` module, except `info.platform == "chromium" && info.application != "opera"` in which case it should be `chrome` (as we don't have separate sub-forums for all Chromium forks). 
    11  
    12 For reference, see the [https://hg.adblockplus.org/adblockpluschrome/file/cfd6fc9d1c67/options.js#l110 logic of the old options page]. 
     16* The "Go to Forum" link should link to `https://adblockplus.org/redirect?link=<application>_support&lang=<lang>`, where `<application>` is the `application` from the `info` module, except `info.platform == "chromium" && info.application != "opera"` in which case it should be `chrome` (as we don't have separate sub-forums for all Chromium forks). [https://bitbucket.org/adblockplus/spec/src/03e3a9ed82765a5425c85cc0c442167c55fbf203/spec/abp/options-page.md?at=master&fileviewer=file-view-default#markdown-header-bullet-list-note-links-are-specific-to-language-settings See here]. [https://hg.adblockplus.org/adblockpluschrome/file/cfd6fc9d1c67/options.js#l110 logic of the old options page]. 
     17* Find out how to turn on DNT should behave as specified [https://bitbucket.org/adblockplus/spec/src/03e3a9ed82765a5425c85cc0c442167c55fbf203/spec/abp/options-page.md?at=master&fileviewer=file-view-default#markdown-header-do-not-track-conditions here]