Opened 2 years ago

Closed 2 years ago

#5703 closed change (fixed)

Add CSS fallback for hidden attribute to website-defaults

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29550643

Description

Background

We may want to use the hidden attribute to hide elements on the page.

Most current browsers automatically add display: none; to elements with this attribute, but some browsers we support do not. See http://caniuse.com/#feat=hidden

What to change

Add the following CSS to website-defaults _reset.scss

[hidden]
{
  display: none;
}

Change History (7)

comment:1 follow-up: Changed 2 years ago by ire

Priority P2 because I am planning on using this attribute in https://issues.adblockplus.org/ticket/4925

comment:2 in reply to: ↑ 1 Changed 2 years ago by juliandoucette

  • Ready set

Replying to ire:

Priority P2 because I am planning on using this attribute in https://issues.adblockplus.org/ticket/4925

Ack.

comment:3 Changed 2 years ago by juliandoucette

  • Priority changed from P2 to P3

Reducing priority because this is not blocking something of higher priority.

comment:4 Changed 2 years ago by ire

  • Owner set to ire

comment:5 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by abpbot

comment:7 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.