Opened 2 years ago

Closed 3 months ago

#5707 closed defect (rejected)

Anti-adblock subscription is not restored

Reported by: Ross Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABP 1.13.3.1838
Chrome 61 / Windows 10
Opera 47 / Windows 10

ABP 0.9.11.1849
Edge 40 / Windows 10

How to reproduce

  1. Delete all of the subscriptions present after install.
  2. Close and restart the browser.
  3. Re-open the options page.

Observed behaviour

If all subscriptions are removed, only the EasyList subscription is restored on browser restart.

Expected behaviour

If all subscriptions are removed, both the EasyList and the Anti-Adblock subscription should be restored (but with Anti-Adblock disabled, as on install).

Change History (2)

comment:1 Changed 2 years ago by sebastian

  • Cc kzar added
  • Component changed from Core to Platform

There are two scenarios here:

  1. There are no subscription data at all when the extension is loaded.
    • In this case subscriptions are reset to default and the first run page shows up with a message explaining that default subscriptions have been added again.
  2. There are no subscriptions other than Acceptable Ads and the Anti-Adblockling list, and no custom filters, when the the extension is loaded.
    • Only the default adblocking list (i.e. EasyList, possibly bundled with a language specific complementary list) is added again.

The first scenario is specified in #417. The logic for the second scenario is even older, however, we didn't have the Anti-Adblock list back then. But that logic might still make sense. If there is no filter that might potentially block anything, this is obviously a misconfiguration (if not a data corruption), hence adding the default ad blocking subscription again seems to make sense. But if the Anti-Adblock list is missing there is no indication whether it has been intentionally removed by the user.

comment:2 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.