Opened 3 years ago

Closed 3 years ago

#5708 closed change (duplicate)

Replace all uses of the background page's require in the popup with messaging

Reported by: kzar Assignee:
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: greiner, trev, sebastian, mjethani, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


With issue #5080 and #5535 we're switching over to use Webpack instead of our hand-rolled module system. Once we've done that we'll no longer be able to use the require function from the background page in our popup.

In issue #5593 we've begun using messaging to the background page where previously the require function was used directly. We now need to finish that work.

What to change

Change adblockpluschrome/popup.js, adblockpluschrome/notification.js and adblockpluschrome/stats.js to remove all uses of require from the background page. Instead use messaging to communicate with the background page.

Change History (3)

comment:1 Changed 3 years ago by kzar

  • Cc mjethani hfiguiere added

comment:2 Changed 3 years ago by kzar

  • Description modified (diff)

comment:3 Changed 3 years ago by kzar

  • Blocked By 5593 removed
  • Blocking 5080 removed
  • Resolution set to duplicate
  • Status changed from new to closed

We decided to do this as a part of #5593, so closing this as a duplicate.

Note: See TracTickets for help on using tickets.