Opened on 09/18/2017 at 01:28:11 PM

Closed on 09/19/2017 at 01:44:14 PM

#5708 closed change (duplicate)

Replace all uses of the background page's require in the popup with messaging

Reported by: kzar Assignee:
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: greiner, trev, sebastian, mjethani, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


With issue #5080 and #5535 we're switching over to use Webpack instead of our hand-rolled module system. Once we've done that we'll no longer be able to use the require function from the background page in our popup.

In issue #5593 we've begun using messaging to the background page where previously the require function was used directly. We now need to finish that work.

What to change

Change adblockpluschrome/popup.js, adblockpluschrome/notification.js and adblockpluschrome/stats.js to remove all uses of require from the background page. Instead use messaging to communicate with the background page.

Attachments (0)

Change History (3)

comment:1 Changed on 09/18/2017 at 01:34:18 PM by kzar

  • Cc mjethani hfiguiere added

comment:2 Changed on 09/18/2017 at 02:40:03 PM by kzar

  • Description modified (diff)

comment:3 Changed on 09/19/2017 at 01:44:14 PM by kzar

  • Blocked By 5593 removed
  • Blocking 5080 removed
  • Resolution set to duplicate
  • Status changed from new to closed

We decided to do this as a part of #5593, so closing this as a duplicate.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.