#5728 closed change (fixed)

Replace Services.vc.compare

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev, mjethani Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29548719

Description (last modified by trev)

Background

See #5702.

What to change

  • Add an exported function to the coreUtils module, providing the same functionality as Services.vc.compare currently implemented in adblockpluschrome repository.
  • Move version comparator unit tests from adblockpluschrome repository to adblockpluscore.
  • Adapt the code in lib/notification.js to use the new function instead of the Gecko API.
  • Remove the polyfill from _test/_common.js.

Hints for testers

This change affects our emergency notification mechanism, particularly the version selection. Minimal and maximal bounds for extension or application versions should still work correctly. Also, non-trivial version numbers such as "2.99.0.1838beta" or "57.0a1" should be handled correctly.

Change History (6)

comment:1 Changed 22 months ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 22 months ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 22 months ago by trev

  • Description modified (diff)

comment:4 Changed 22 months ago by trev

  • Description modified (diff)

comment:5 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 5728 - Replace Services.vc.compare

comment:6 Changed 22 months ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.