Opened on 09/18/2017 at 06:04:32 PM

Closed on 09/25/2017 at 02:48:41 PM

#5728 closed change (fixed)


Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev, mjethani Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)


See #5702.

What to change

  • Add an exported function to the coreUtils module, providing the same functionality as currently implemented in adblockpluschrome repository.
  • Move version comparator unit tests from adblockpluschrome repository to adblockpluscore.
  • Adapt the code in lib/notification.js to use the new function instead of the Gecko API.
  • Remove the polyfill from _test/_common.js.

Hints for testers

This change affects our emergency notification mechanism, particularly the version selection. Minimal and maximal bounds for extension or application versions should still work correctly. Also, non-trivial version numbers such as "" or "57.0a1" should be handled correctly.

Attachments (0)

Change History (6)

comment:1 Changed on 09/18/2017 at 06:05:54 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/19/2017 at 08:26:59 AM by trev

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 09/19/2017 at 08:28:44 AM by trev

  • Description modified (diff)

comment:4 Changed on 09/19/2017 at 08:39:09 AM by trev

  • Description modified (diff)

comment:5 Changed on 09/25/2017 at 02:47:53 PM by abpbot

A commit referencing this issue has landed:
Issue 5728 - Replace

comment:6 Changed on 09/25/2017 at 02:48:41 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.