Opened 2 years ago

Closed 3 weeks ago

#5732 closed change (rejected)

[emscripten] Stop using i64 arithmetic

Reported by: trev Assignee: rjeschke
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: oleksandr Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

i64 arithmetic is very inefficient with Emscripten. However, we are currently using it when parsing or serializing timestamps.

What to change

Store timestamps as i32 numbers internally (seconds rather than milliseconds). For compatibility with the existing storage format, add three trailing zeros to timestamps when serializing. Also, ignore the last three digits when parsing timestamps. Use a new type for timestamps, so that the generated bindings code can automatically add * 1000 for the property getters and / 1000 for property setters.

Change History (4)

comment:1 Changed 2 years ago by oleksandr

  • Cc oleksandr added

comment:2 Changed 22 months ago by rjeschke

  • Owner set to rjeschke

comment:3 Changed 9 months ago by hfiguiere

This is not a problem if we move to WebAssembly.

See issue #6312

comment:4 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.