Opened 2 years ago

Closed 8 days ago

#5746 closed defect (rejected)

Notification not shown in Edge

Reported by: Ross Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: sebastian, oleksandr, geo Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABP 0.9.11.1849
Edge 40 / Windows 10

How to reproduce

  1. Setup Fiddler (or other proxy) to intercept requests from Edge.
  2. Setup Fiddler/proxy to respond to notification.adblockplus.org/notification.json with the test json below.
  3. Install ABP Edge build.
  4. Wait for notification request from extension.

Observed behaviour

Edge receives the notification but appears to do nothing with it.

Expected behaviour

The same notification.json sent to ABP Chrome (with target as adblockpluschrome) shows a "Test" notification as expected.

Example json

{ \"notifications\": [ { \"targets\": [{ \"extension\": \"adblockplusedge\" }], \"id\": \"1\", \"message\": { \"en-US\": \"Test\" }, \"severity\": \"normal\", \"title\": { \"en-US\": \"Test\" } } ], \"version\": \"201707281538\" }

Change History (5)

comment:1 Changed 2 years ago by Ross

To get Fiddler to respond add the following to OnBeforeResponse in Rules > Customize Rules:

if( oSession.PathAndQuery.Contains("notification.json"))
{

var res = "escapedjsonstringhere";
oSession.utilSetResponseBody(res);

}

comment:2 Changed 7 months ago by sebastian

  • Cc geo added

Also see #7347.

Last edited 7 months ago by sebastian (previous) (diff)

comment:3 Changed 5 months ago by geo

I'm not sure what the original issue was, but currently, the notifications API is still broken on Edge, so only popup notifications will be displayed.

One thing, for the default type, the title and message are missing on Edge.

comment:4 Changed 9 days ago by greiner

  • Component changed from Unknown to Platform

comment:5 Changed 8 days ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.