Changes between Initial Version and Version 1 of Ticket #5747


Ignore:
Timestamp:
12/04/2017 03:35:20 PM (3 years ago)
Author:
saroyanm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5747

    • Property Priority changed from Unknown to P4
    • Property Ready set
  • Ticket #5747 – Description

    initial v1  
    11=== Background === 
    2 After several design iterations we finally have a final version of the new options page (See #5158). 
    3 We are making a lot of Async calls in the code and handling in the "traditional" way, but we might want to use Promises instead. 
     2We are making a lot of Async calls in the new options page using [https://hg.adblockplus.org/adblockplusui/file/tip/ext/content.js#l67 browser.runtime.sendMessage] (Dont' mix with actual [https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/sendMessage browser.runtime.sendMessage] which return promise). 
     3In order to make the code more modern and be able get use of Promises instead of regular Async calls we should update the Options Page accordingly, while all targeted browsers we plan to ship new options page support Promises. 
    44 
    55=== What to change === 
    6 [To be defined] 
     6Use Promises for Async calls in the desktop version of options page.