Opened 2 years ago

Closed 2 years ago

#5752 closed change (fixed)

Remove the "safari" build target from buildtools

Reported by: tlucas Assignee:
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: kzar, sebastian, kvas, fhd Blocked By:
Blocking: #5757 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29562614/

Description (last modified by sebastian)

Background

The safari branch in adblockpluschrome is no longer actively maintained. Given the significant differences to other browsers extension implementations, including major limitations, and the comparable low numbers of Adblock Plus for Safari users on macOS, it is no longer worth it.

We might still release infrequent minor updates of Adblock Plus for Safari, but there would be no need to update the buildtools dependency for these releases. The long-term plan is to eventually port Adblock Plus for iOS, to macOS, which will then replace the traditional browser extension for Safari.

Moreover, since jsHydra integration has been removed (#4552), newer versions of buildtools can no longer build Adblock Plus for Safari, anymore, anyway.

What to change

Remove the buildtools' features for safari extensions:

  • Remove packagerSafari.py, xarfile.py
  • Remove the safari types and targets from build.py
  • Remove safariInfo.js.tmpl and Info.plist.tmpl from templates
  • Remove the safari target from releaseAutomation.py

Change History (10)

comment:1 Changed 2 years ago by kzar

  • Description modified (diff)

comment:2 Changed 2 years ago by sebastian

  • Description modified (diff)

Note that sitescripts imports packagerSafari and xarfile in order to extract metadata for the development builds. While we can keep using an old version of buildtools for building the Safari extension, sitescripts must remain compatible with the latest buildtools.

While in low maintenance mode, (unlike for legacy Gecko extensions, see ticket:5751#comment:4) we occasionally still have to release updates of Adblock Plus for Safari until we eventually discontinued/replaced it. Therefore I'm afraid we cannot abandon the development builds yet.

Still there are good reasons to already remove the Safari packager from buildtools. So I suggest to just move the related logic into sitescripts, for the time being.

Last edited 2 years ago by sebastian (previous) (diff)

comment:3 Changed 2 years ago by sebastian

  • Summary changed from Remove safari features from the buildtools to Remove the "safari" build target from buildtools

comment:4 Changed 2 years ago by tlucas

  • Blocked By 5758 added

comment:5 Changed 2 years ago by sebastian

  • Blocked By 5758 removed

comment:6 Changed 2 years ago by sebastian

  • Blocking 5757 added

comment:7 Changed 2 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:8 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5752 - Removing safari support

comment:10 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.