Opened 2 years ago

Closed 2 years ago

#5754 closed change (fixed)

Update promo image on adblockbrowser.org

Reported by: wspee Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords: goodfirstbug, content
Cc: ire, juliandoucette, wspee, p.pastourmatzis, tpregueiro Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29589602

Description (last modified by wspee)

Background

With the release of ABB iOS 2.0 and the upcoming cross promotion we want to update adblockbrowser.org.

What to change

Replace the promo image on the right side of adblockbrowser.org with the new promo image:


Attachments (4)

promo-image_withghost.png (93.5 KB) - added by wspee 2 years ago.
promo-image.png (82.6 KB) - added by wspee 2 years ago.
promo-image_3.png (46.6 KB) - added by wspee 2 years ago.
abb.new.png (144.5 KB) - added by wspee 2 years ago.

Download all attachments as: .zip

Change History (23)

Changed 2 years ago by wspee

comment:1 Changed 2 years ago by wspee

  • Cc ire juliandoucette added
  • Component changed from Unknown to Websites
  • Milestone set to adblockplus.org 1.1.0
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 2 years ago by wspee

  • Ready unset

On hold for now, we might want to update the image again.

Changed 2 years ago by wspee

comment:3 Changed 2 years ago by wspee

  • Description modified (diff)
  • Ready set

Changed 2 years ago by wspee

comment:4 Changed 2 years ago by wspee

  • Description modified (diff)

comment:5 Changed 2 years ago by juliandoucette

  • Cc wspee added

@wpsee can you confirm that this image is final? (I'm not sure that it's an improvement :/)

comment:6 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)

Changed 2 years ago by wspee

comment:7 Changed 2 years ago by wspee

  • Cc t.pregueiro@… p.pastourmatzis@… added

@Tiago,Paul This is how abb.org will look like after the change. After the back and forth can you please confirm that this is the right image?


comment:8 Changed 2 years ago by ire

  • Owner set to ire

comment:9 Changed 2 years ago by ire

@wspee: This was marked as ready, but looking at the comments it doesn't seem like this is confirmed. Is this ready to implement?

FTR I agree with Julian. I'm not sure this is an improvement, the image doesn't convey to me that it's a browser that blocks ads

comment:10 Changed 2 years ago by ire

  • Owner ire deleted

comment:11 Changed 2 years ago by juliandoucette

  • Milestone adblockplus.org 1.1.0 deleted

comment:12 Changed 2 years ago by juliandoucette

  • Cc p.pastourmatzis tpregueiro added; t.pregueiro@… p.pastourmatzis@… removed

Properly CC'd Paul and Tiago. Please see comment:5 - comment:9.

comment:13 Changed 2 years ago by juliandoucette

  • Keywords goodfirstbug content added
  • Ready unset

comment:14 Changed 2 years ago by tpregueiro

@wspee LGTM

comment:15 Changed 2 years ago by wspee

  • Ready set

@tpregueiro
Ok, thanks.

comment:16 Changed 2 years ago by ire

  • Owner set to ire

comment:17 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:18 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5754 - Update promo image on adblockbrowser.org

comment:19 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.