#5757 closed change (fixed)

Update buildtools dependency after dropping support for legacy build targets

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, sebastian, fhd, trev Blocked By: #5751, #5752, #5845, #5942
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29589691/

Description (last modified by tlucas)

Background

With #5751 and #5752, we drop support, for the gecko and safari build targets, from buildtools. While new versions of buildtools no longer need to be able to build extensions for these target platforms, sitescript currently relies on functionality provided by buildtools in order to extract metadata of these legacy extensions from the development builds.

We can defer this dependency update until we can drop the development builds of legacy Gecko extensions, which is as soon as Firefox 57 is released. However, we cannot drop development builds for Safari as soon, see ticket:5752#comment2.

What to change

  • Remove support for development builds of legacy Gecko extension.
  • Change the target of gecko development build from gecko-webext to gecko
  • Move the Safari-related code, previously imported from buildtools, to sitescripts.
  • Update the buildtools dependency to:
mercurial git
39a589de5c18 0373bbf

Included changes in buildtools

The list of changes imported by this is:

Ticket Summary Component
#5939 Crowdin downloads suffixed translations to the wrong folder Automation
#5916 Locale strings are broken in adblockpluschrome when building from Windows Automation
#5915 adblockpluschrome won't build under Windows Automation
#5913 ensure_dependencies.py doesn't install Node.js dependencies on Windows Automation
#5895 Let npm not try to resolve optional dependencies Automation
#5877 First run page is missing some text Automation
#5857 ensure_dependencies.py does not resolve Node.js dependencies if a previous installation failed Automation
#5856 Remove the package-lock.json file from buildtools Automation
#5845 Rename "gecko-webext" build target to "gecko" Automation
#5815 Upload to Crowdin with non-ASCII characters in source translation fails Automation
#5777 Upload to Crowdin is not working (presumably due to API change) Automation
#5763 Target languages supported by Firefox Automation
#5752 Remove the "safari" build target from buildtools Automation
#5751 Remove the "gecko" build target from buildtools Automation
#5736 Release automation aborts without reason Automation
#5668 Version number in AppxMainfest.xml must include build number Automation
#5666 Version number in AppxMainfest.xml must end with ".0" Automation
#5660 [webextensions] First run page not opened in Firefox 50 Automation
#5649 AppxMainfest.xml includes truncated version umber Automation
#5577 let build.py allow non-numerical build numbers for gecko-webext Automation
#5560 Specify the jsdoc dependency, instead of expecting it to be installed globally Automation
#5559 Have ensure_dependencies.py install (production) Node.js dependencies when updating a dependency Unknown
#5535 Begin using webpack for script bundling in the Chrome packager Automation
#5477 Buildtool doesn't import localization string placeholders on build Automation
#5448 Add content_security_policy to the manifest.json for Chrome-extensions Automation
#5383 Add tests for the Chrome and Firefox packagers Automation
#5113 Add support to buildtools/packagerChrome.py for json files in top level directory Automation
#5085 Separate "info" module for Microsoft Edge from chromeInfo.js.tmpl Automation
#5060 Move module code from adblockpluschrome/lib/compat.js into the modules template Automation
#5049 Allow embedded WebExtensions in gecko packager Automation
#5028 Use the browser extension API via the "browser" (instead of "chrome") namespace Platform
#5012 Support "minimum_opera_version" in Chrome/Opera packager Automation
#4906 change cloning in ensure_dependecies Automation
#4882 Rename flake8-abp to flake8-eyeo Sitescripts
#4720 Edge packager does not support devenv Automation
#4354 Release automation commits and pushes local changes Automation
#4096 qunit/index.html is being included in Chrome builds Automation
#3967 Create directories for mapped files if they don't already exist Automation


4d26be1c438e Noissue - Use sets in build.py were appropriate Tristan Lucas
e9059b211107 Noissue - Backed out 08002782f3e3 Sebastian Noack
5c275f316334 Noissue - Removed superfluos per-file-ignore for A103, fixing an X100 Sebastian Noack
2ee884010cf5 Noissue - Fixed order of entries in package-lock.json Sebastian Noack
293593da6033 Noissue - Added flake8-docstrings Sebastian Noack
94770c909a2d Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 Sebastian Noack
64e5f6c97e81 Noissue - Remove some dead code Wladimir Palant
e2a22ff89969 Noissue - Fixed new flake8 errors Sebastian Noack

The relevant changes are #5751, #5752 and #5845

Integration Notes

Note: Before this change lands, the sitescripts.ini on the server must be updated, removing extensions of the type gecko-webext!

Change History (9)

comment:1 Changed 21 months ago by sebastian

  • Blocked By 5751, 5752 added
  • Blocking 5751 removed
  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from No longer create "gecko" nightly builds to Update buildtools dependency after dropping support for legacy build targets

comment:2 Changed 21 months ago by sebastian

  • Blocked By

comment:3 Changed 21 months ago by sebastian

  • Blocked By

comment:4 Changed 21 months ago by tlucas

  • Blocked By 5845 added
  • Description modified (diff)

comment:5 Changed 21 months ago by tlucas

  • Cc trev added
  • Owner set to tlucas

comment:6 Changed 20 months ago by tlucas

  • Blocked By 5942 added

comment:7 Changed 20 months ago by tlucas

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 19 months ago by abpbot

comment:9 Changed 19 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.