Use relative require paths in adblockpluschrome

[kzar]

Background

Previously we've used our own system for managing modules, the files bundled were specified manually in the metadata and then modules were required with no path part.

With the switch to using webpack for bundling, bundled files are resolved at build time automatically. When modules are required with no path part webpack will check the hard-coded resolve paths for suitable files, but that has several limitations / problems.

What to change

Change all require calls in adblockpluschrome to use relative paths. E.g.

In adblockpluschrome/lib/whitelisting.js this require:

const {RegExpFilter} = require("filterClasses");

should become:

const {RegExpFilter} = require("../adblockpluscore/lib/filterClasses");

The legacy prefix syntax should be replaced too. E.g.

In adblockpluschrome/include.preload.js this require:

let {ElemHideEmulation} = require("content_elemHideEmulation");

should become:

let {ElemHideEmulation} = require("./adblockpluscore/lib/content/elemHideEmulation");

[abpbot]

A commit referencing this issue has landed:
​Issue 5760 - Use relative require

[Ross]

Done. I have not found any regressions related to this change.

ABP 3.0.4.2042
Firefox 59 / 55 / 51 / Windows 10
Chrome 66 / 58 / 49 / Windows 7
Opera 52 / 45 / 36 / Windows 10