#5765 closed change (fixed)

Remove custom spacing units in help.eyeo.com

Reported by: ire Assignee: ire
Priority: P5 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29633564/

Description

Background

We currently have the following custom spacing units in the help.eyeo.com SCSS variables:

$xl: 60px;
$lg: 30px;
$md: 15px;
$sm: 10px;
$xs: 5px;

What to change

We have spacing units in website-defaults already, so find a way to use them instead.

Change History (7)

comment:1 Changed 13 months ago by ire

@juliandoucette: The current website-default spacing variables are much more limited:

$large-space: 4em !default;
$medium-space: 2em !default;
$small-space: 1em !default;

Plus, using ems is not always what we want. Should we add more nuance to the website-defaults spacing variables (and add more static spacers as well?)

comment:2 Changed 11 months ago by ire

  • Priority changed from Unknown to P5

Marking this P5 until we decide on this.

comment:3 follow-up: Changed 11 months ago by juliandoucette

Can you provide a few examples of where static values are appropriate on help.eyeo.com?

comment:4 in reply to: ↑ 3 Changed 10 months ago by ire

  • Owner set to ire
  • Ready set

Replying to juliandoucette:

Can you provide a few examples of where static values are appropriate on help.eyeo.com?

I can't remember what I was referring to anymore :/

I'll go ahead and start on this and if I run into any blockers I'll bring it up during review

comment:5 Changed 10 months ago by ire

  • Milestone set to help.eyeo.com 1.0.0
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 5765 - Remove custom spacing units in help.eyeo.com

comment:7 Changed 10 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.