Opened 2 years ago

Closed 2 years ago

#5774 closed change (fixed)

Rewrite Safari Action Extension in Swift

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29584621/

Description

Background

With the upcoming Swift rewrite, several parts of code need to be rewritten. This ticket is for the Swift rewrite of the Safari Action Extension.

What to change

There are several classes that need to be rewritten in Swift (from Obj-C).

Attachments (1)

abp-app-ext-1024-appstore@1x.png (11.2 KB) - added by dzhang 2 years ago.
Action extension app icon with a file size of 11 KB.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)

comment:3 Changed 2 years ago by ashephard

Updated the codereview with another patchset.

Changed 2 years ago by dzhang

Action extension app icon with a file size of 11 KB.

comment:4 Changed 2 years ago by dzhang

I came up with a compromise to get rid of the icon warning for the app extension. I made a new icon reduced to 11 KB, down from 44 KB, by saving it as an 8-bit file. It is not used by the app store but is used by Xcode as a target icon.

comment:5 Changed 2 years ago by ashephard

I've included the icon in the latest patchset and have sent an email containing the patch file to Daniel.

comment:6 Changed 2 years ago by ashephard

  • Milestone set to Adblock-Plus-for-iOS-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.