Opened on 09/25/2017 at 01:49:39 PM

Closed on 11/13/2017 at 09:58:57 AM

#5774 closed change (fixed)

Rewrite Safari Action Extension in Swift

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



With the upcoming Swift rewrite, several parts of code need to be rewritten. This ticket is for the Swift rewrite of the Safari Action Extension.

What to change

There are several classes that need to be rewritten in Swift (from Obj-C).

Attachments (1)

abp-app-ext-1024-appstore@1x.png (11.2 KB) - added by dzhang on 11/10/2017 at 01:06:57 AM.
Action extension app icon with a file size of 11 KB.

Download all attachments as: .zip

Change History (7)

comment:1 Changed on 10/06/2017 at 09:12:31 AM by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/20/2017 at 02:15:31 PM by ashephard

  • Review URL(s) modified (diff)

comment:3 Changed on 10/31/2017 at 03:24:41 PM by ashephard

Updated the codereview with another patchset.

Changed on 11/10/2017 at 01:06:57 AM by dzhang

Action extension app icon with a file size of 11 KB.

comment:4 Changed on 11/10/2017 at 01:07:37 AM by dzhang

I came up with a compromise to get rid of the icon warning for the app extension. I made a new icon reduced to 11 KB, down from 44 KB, by saving it as an 8-bit file. It is not used by the app store but is used by Xcode as a target icon.

comment:5 Changed on 11/10/2017 at 12:50:27 PM by ashephard

I've included the icon in the latest patchset and have sent an email containing the patch file to Daniel.

comment:6 Changed on 11/13/2017 at 09:58:57 AM by ashephard

  • Milestone set to Adblock-Plus-for-iOS-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
Note: See TracTickets for help on using tickets.