Opened 2 months ago

Closed 8 weeks ago

#5776 closed change (fixed)

Update adblockpluscore dependency to d4ed3916793a

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-3.0-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29555778

Description (last modified by sebastian)

Background

With #5728, usage of Service.vc.compare() has been removed from adblockpluscore, causing the polyfill in lib/compat.js being unused. There is some other dead code in that script as well.

With #5797, obsolete arguments have been removed from the ElemHideEmulation constructor.

What to change

  • Update adblockpluscore dependency to d4ed3916793a.
  • Remove any dead code from lib/compat.js.
  • Adapt usage of ElemHideEmulation for changes in #5797.

Change History (4)

comment:1 Changed 2 months ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 months ago by sebastian

  • Description modified (diff)
  • Summary changed from Update adblockpluscore dependency and remove dead code from lib/compat.js to Update adblockpluscore dependency to d4ed3916793a

comment:3 Changed 8 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a

comment:4 Changed 8 weeks ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.