Changes between Version 5 and Version 8 of Ticket #5777


Ignore:
Timestamp:
09/26/2017 09:47:31 AM (3 years ago)
Author:
tlucas
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5777

    • Property Status changed from new to reviewing
    • Property Summary changed from Crowdin interface in buildtools is broken to Upload to Crowdin is not working (presumably due to API change)
    • Property Owner set to tlucas
  • Ticket #5777 – Description

    v5 v8  
    1515 
    1616=== Note === 
    17 - This will also break the Crowdin integration in the CMS repository. This might not be recognized due to the tests mocking the Crowdin API. 
     17- This should '''not''' affect the Crowdin integration in the CMS repository. 
    1818- Uploading new files is also failing, but with a HTTP 400 error instead of silently. 
    1919- Requests to the languages_list endpoint are broken too now since they've moved the languages into the `data` key. 
     20 
     21 
     22=== Hints for testers === 
     23The patch affects all four crowdin related build.py commands, hence all of them should be verified: 
     24 
     25{{{ 
     26./build.py -t chrome setuptrans <project-api-key> 
     27}}} 
     28''should configure the target languages of the crowdin project'' 
     29 
     30{{{ 
     31./build.py -t chrome translate <project-api-key> 
     32}}} 
     33''should update the crowdin master files i.e. update existing source files, add new source files, delete obsolete source files'' 
     34 
     35{{{ 
     36./build.py -t chrome uploadtrans <project-api-key> 
     37}}} 
     38''should upload locally available translations (fails for files which are not present in the crowdin master)'' 
     39 
     40{{{ 
     41./build.py -t chrome gettranslations <project-api-key> 
     42}}} 
     43''should download all available translations from crowdin'' 
  • Ticket #5777 – Review URL(s)

    v5 v8  
     1https://codereview.adblockplus.org/29556601