Opened 3 years ago

Last modified 3 years ago

#5777 closed defect

Crowdin interface in buildtools is broken — at Version 4

Reported by: tlucas Assignee:
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: erick, kzar, sebastian, kvas, jsonesen, Shikitita Blocked By:
Blocking: #5763 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29556601

Description (last modified by kzar)

How to reproduce

  1. Change the target language of the test project to German only.
  2. Go to the repo "adblockpluschrome".
  3. Change "basename" in "metadata.chrome" to this-is-very-much-a-test-proje.
  4. Try to update the target translations for the project:
    ./build.py -t chrome setuptrans <project-api-key>
    

Observed behaviour

The call succeeds, when visiting the temporarily configured project and checking the target languages, nothing has changed.

Expected behaviour

The call should succeed and the Crowdin project should have every currently available language in adblockpluschrome configured as a target translation.

Note

  • This will also break the Crowdin integration in the CMS repository. This might not be recognized due to the tests mocking the Crowdin API.
  • Uploading new files is also failing, but with a HTTP 400 error instead of silently.
  • Requests to the languages_list endpoint are broken too now since they've moved the languages into the data key.

Change History (4)

comment:1 Changed 3 years ago by kzar

  • Cc Shikitita added
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

Tristan and I were chatting about this in IRC, it looks like Crowdin have changed their API. Firstly the language list is now inside the data key, this change fixed that problem. Secondly the add-file endpoint is returning 400 when I try to add files using the translate command. It's more than possible there were other breaking changes too :(, I didn't have any more time to look into it.

It looks like we'll have to make changes to both buildtools and cms to get our translation integrations working again.

comment:2 Changed 3 years ago by kzar

  • Description modified (diff)

comment:3 Changed 3 years ago by kzar

  • Description modified (diff)

comment:4 Changed 3 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.