Opened 2 years ago

Closed 23 months ago

#5778 closed defect (fixed)

Hide More filters section when there is no filter

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: jeen Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29555849/

Description (last modified by saroyanm)

Environment

Any browser

How to reproduce

  1. Run ./test_server.py from inside the adblockplusui repository.
  2. Go to ​http://localhost:5000/new-options.html
  3. Observe

Observed behaviour

No empty message and section looks useless

Expected behaviour

This section doesn't exist at all when there is no filter in the section

Change History (7)

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:2 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:3 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:4 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:5 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 23 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.