Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#5788 closed defect (fixed)

Retest Notification AB machinery

Reported by: wspee Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29556615/
https://codereview.adblockplus.org/29583565/

Description (last modified by wspee)

Background

This is an issue to track the re-test of #2981.

What to change

Deploy the following notification:

From: https://codereview.adblockplus.org/29556615/

Notification: 3

severity = information
target = extensionVersion>=10 extensionVersion<=1

[1]
title.en-US = Test #2981 variant #1
message.en-US = This is a test notification to test #2981 variant #1
sample = 0.005

[2]
title.en-US = Test #2981 variant #2
message.en-US = This is a test notification to test #2981 variant #2
sample = 0.005

[2]
title.en-US = Test #2981 variant #3
message.en-US = This is a test notification to test #2981 variant #3
sample = 0.005

This notification should yield 3 variants that are downloaded by 0.5% of the clients but never be shown. The remaining clients should get an empty notification.json.

And see if the effects described in #2981 still occur.

Note

The test was started on Tue, 17 Oct 2017 16:50:22 +0200 and ended on Thu, 19 Oct 2017 13:58:09 +0200.

Data will be logged to access_log_notification on all filter servers.

Example excerpt of /var/log/nginx/access_log_notification

10.8.0.1 - - [17/Oct/2017:09:31:57 +0000] "GET /notification.json?lastVersion=201710161200-2%2F1 HTTP/1.1" 200 323 "-" "Wget/1.18 (linux-gnu)" "-" https "-" "notification.adblockplus.org" "-" 201710170931-3/0

Note how the new version string showing the group the client ended up in is appended to the end of the line.

Change History (12)

comment:1 Changed 2 years ago by wspee

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by wspee

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:3 Changed 2 years ago by wspee

  • Description modified (diff)

comment:4 Changed 22 months ago by wspee

  • Description modified (diff)

comment:5 Changed 22 months ago by wspee

  • Description modified (diff)

comment:6 Changed 22 months ago by wspee

  • Description modified (diff)

comment:7 Changed 22 months ago by abpbot

comment:8 Changed 22 months ago by wspee

The test started at ~Tue, 17 Oct 2017 16:50:22 +0200

comment:9 Changed 22 months ago by wspee

  • Review URL(s) modified (diff)

comment:10 Changed 22 months ago by abpbot

comment:11 Changed 22 months ago by wspee

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 22 months ago by Kirill

I confirm that the data looks good. The distribution was ~0.0065 for all groups.

Note: See TracTickets for help on using tickets.