Opened 2 years ago

Closed 2 years ago

#5797 closed change (fixed)

Remove obsolete arguments from ElemHideEmulation constructor

Reported by: sebastian Assignee: sebastian
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29556808

Description (last modified by sebastian)

Background

Passing the window object to the ElemHideEmulation constructor was only necessary for the legacy Gecko extension, which is deprecated now.

Passing a callback to retrieve the element hiding emulation patterns asynchronously was only necessary so that these can be provided by a separate message, which is no longer the case (see #5781).

What to change

Remove the window and getFiltersFunc arguments from the ElemHideEmulation constructor. Make ElemHideEmulation.apply() take the patterns as an argument instead.

Change History (5)

comment:1 Changed 2 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 2 years ago by hfiguiere

  • Cc hfiguiere added

comment:4 Changed 2 years ago by abpbot

comment:5 Changed 2 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.