Opened 5 years ago

Closed 3 years ago

#58 closed change (fixed)

[meta] ABP for IE 1.1 post-release cleanup

Reported by: trev Assignee: oleksandr
Priority: P3 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: meta
Cc: oleksandr Blocked By: #59, #60, #61, #62, #63, #64, #65, #66, #67, #69, #70, #71, #72, #75, #76
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by philll)

Background

With https://hg.adblockplus.org/adblockplusie/rev/b7c285b78846 we released ABP for IE in version 1.1. We now need to do some cleanup.

What to change

Do some post-release cleanup of ABP for IE 1.1 according to the following issues:

Ticket Status Resolution Summary Owner
#59 closed fixed [ABP IE 1.1 cleanup] Make url a parameter to Updater::Update(), get rid of Updater::SetUrl() fhd
#60 closed fixed [ABP IE 1.1 cleanup] Remove CPluginSettings::m_subscriptions member
#61 closed fixed [ABP IE 1.1 cleanup] Parameter type of FilterLoader() function should be LPVOID
#62 closed fixed [ABP IE 1.1 cleanup] Use better names for local FilterLoader() variables
#63 closed fixed [ABP IE 1.1 cleanup] Reduce indentation level in CPluginTabBase::InjectABP()
#64 closed fixed [ABP IE 1.1 cleanup] Replace tabs by spaces in ieFirstRun.js
#65 closed fixed [ABP IE 1.1 cleanup] Fix the approach used by ieFirstRun.js oleksandr
#66 closed fixed [ABP IE 1.1 cleanup] Remove PROC_GET_APP_LOCALE constant
#67 closed fixed [ABP IE 1.1 cleanup] Use MessageBoxW() explicitly in engine/Main.cpp
#69 closed fixed [ABP IE 1.1 cleanup] Simplify plugin enabling/disabling
#70 closed fixed [ABP IE 1.1 cleanup] Fix x64 warnings in ToUtf8String(), ToUtf16String(), GetDllDir(), Communication::Pipe::WriteMessage(): size_t needs to be converted to DWORD explicitly. fhd
#71 closed fixed [ABP IE 1.1 cleanup] Fix x64 warning in OutputBuffer::WriteString(): size_t needs to be converted to SizeType explicitly.t fhd
#72 closed fixed [ABP IE 1.1 cleanup] Make sure that it isn't possible to start two update checks in parallel.
#75 closed fixed [ABP IE 1.1 cleanup] Make sure update requests are using gzip compression
#76 closed fixed [ABP IE 1.1 cleanup] Check the 4oD player not loading error:


Change History (15)

comment:1 Changed 5 years ago by philll

  • Description modified (diff)

comment:2 Changed 5 years ago by philll

  • Blocked By 59 added

comment:3 Changed 5 years ago by philll

  • Blocked By 60 added

comment:4 Changed 5 years ago by philll

  • Blocked By 61 added

comment:5 Changed 5 years ago by philll

  • Blocked By 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76 added

comment:6 Changed 5 years ago by trev

  • Reporter changed from philll to trev

comment:7 Changed 5 years ago by fhd

  • Priority changed from Unknown to P3
  • Status changed from new to accepted

comment:8 Changed 5 years ago by fhd

  • Status changed from accepted to assigned

comment:9 Changed 5 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:10 Changed 5 years ago by trev

  • Keywords meta added

comment:11 Changed 3 years ago by eric@…

  • Platform set to Internet Explorer
  • Ready unset
  • Tester set to Unknown

comment:12 Changed 3 years ago by oleksandr

  • Blocked By 68 removed

comment:13 Changed 3 years ago by oleksandr

  • Blocked By 73 removed

comment:14 Changed 3 years ago by oleksandr

  • Blocked By 74 removed

comment:15 Changed 3 years ago by oleksandr

  • Cc oleksandr added
  • Ready set
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.