Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#580 closed defect (fixed)

"Disable on this page only" should discard the final # from URLs

Reported by: Gingerbread Man Assignee: saroyanm
Priority: P2 Milestone: Adblock-Plus-2.6.4-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5734888082767872/

Description

Environment

Nightly 2014-05-29 • Adblock Plus 2.6.1.3824

How to reproduce

  1. Go to https://adblockplus.org/en/firefox#
  2. Click the Adblock Plus icon and choose "Disable on this page only".
  3. Go to https://adblockplus.org/en/firefox and https://adblockplus.org/en/firefox#key-facts.

Observed behavior

  1. The Adblock Plus icon remained red. The filter created was

@@|https://adblockplus.org/en/firefox#|$document

  1. The Adblock Plus icon remained red and the "Disable on this page only" was unchecked, though that's the same page that was whitelisted earlier.

Expected behavior

"Disable on this page only" should discard the final # from the URL when saving the filter.
@@|https://adblockplus.org/en/firefox|$document

Forum thread

https://adblockplus.org/forum/viewtopic.php?f=11&t=23351

Change History (8)

comment:1 Changed 6 years ago by philll

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 6 years ago by mapx

  • Cc mapx added

comment:3 Changed 6 years ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 6 years ago by saroyanm

  • Status changed from new to reviewing

comment:5 Changed 6 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:6 Changed 6 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform set to Firefox/Firefox Mobile

comment:8 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.