Opened 2 years ago

Closed 2 years ago

#5800 closed change (fixed)

Add option to specify a list of V8 libraries

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29557565/

Description (last modified by asmirnov)

Background

For integrating libadblockplus-android into other products like Chromium we need to be able to link with prebuilt shared v8 library in order to use product's V8 instead of our built-in v8. Libadblockplus is required to be built using according shared library(-ies) (#5799).

What to change

Add option to link with existing v8 library (libswev8.so in Qualcomm's Aurora or libv8.cr.so in pure Chromium).

Change History (6)

comment:1 Changed 2 years ago by asmirnov

  • Description modified (diff)

comment:2 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by asmirnov

  • Cc sergz added

comment:4 Changed 2 years ago by asmirnov

  • Summary changed from Add option to specify V8 library to Add option to specify a list of V8 libraries

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5800 - Add option to specify a list of V8 libraries

comment:6 Changed 2 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.