Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5810 closed change (fixed)

Use "specialization" as Subscription display title

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: vickyyu Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29559597/

Description

Background

We provide settings UI in libadblockplus-android to manage subscriptions. In filters dialog a list of subscriptions is shown (see attachment #1). At this time subscription "title" property from https://github.com/adblockplus/adblockpluscore/blob/master/chrome/content/ui/subscriptions.xml is being used and it's not human-friendly actually. According to mockups for our partners it should look like "German", "Russian", etc. We need to adjust it.

What to change

Use "specialization" property as Subscription display title

Attachments (2)

image.png (85.1 KB) - added by asmirnov 2 years ago.
current UI in libadblockplus-android
device-2017-09-29-161223.png (64.7 KB) - added by asmirnov 2 years ago.
With "specialization" as display title

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by asmirnov

current UI in libadblockplus-android

Changed 2 years ago by asmirnov

With "specialization" as display title

comment:1 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by vickyyu

  • Cc vickyyu added

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5810 - Use "specialization" as Subscription display title

comment:4 Changed 2 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5810 - Use "specialization" as Subscription display title

Note: See TracTickets for help on using tickets.