Changes between Version 11 and Version 29 of Ticket #5817


Ignore:
Timestamp:
11/21/2017 03:41:00 PM (2 years ago)
Author:
kzar
Comment:

Annoyingly the error is not a real exception so we can't catch it...

My mistake, the API was promisified I just had to call .catch()!

The "1 second delay" does not work always ?

Well it seems to work reliably for me, but who knows that it would work reliably on a different computer. Hard coding pauses like this is a nasty hack :/

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5817

    • Property Summary changed from webextension: "block element" produces only an empty window to [webextension] "block element" produces only an empty window
    • Property Owner changed from trev to kzar
    • Property Keywords externaldependencies added
    • Property Milestone changed from to Adblock-Plus-for-Firefox-next
  • Ticket #5817 – Review URL(s)

    v11 v29  
    11https://codereview.adblockplus.org/29602561/ 
     2https://codereview.adblockplus.org/29613777/