Opened 2 years ago

Last modified 22 months ago

#5817 closed defect

webextension: "block element" produces only an empty window — at Version 10

Reported by: mapx Assignee: trev
Priority: P1 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords: externaldependencies
Cc: sebastian, trev, mjethani, kzar, hfiguiere Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29602561/
https://codereview.adblockplus.org/29613777/

Description (last modified by trev)

Environment

Windows 10
FF 57.0b4 (64-bit)
ABP 2.99.0.1867beta
Easylist

How to reproduce

go to google page
click ABP icon, click "block element"
select whatever element on page

Observed behaviour

  • an empty window opens - no filters are proposed
  • I tried to close the window => I have to click twice to get it closed

Expected behaviour

..normal behaviour

Situation also reported by the users in forum.

It seems nobody tested a crucial feature.

Background

This is a timing issue, the initialization message is sent to the pop-up before it is ready.

Change History (12)

Changed 2 years ago by mapx

comment:1 Changed 2 years ago by sebastian

  • Cc mjethani added

Changed 2 years ago by mapx

comment:2 Changed 2 years ago by mapx

  • Description modified (diff)

comment:3 Changed 2 years ago by mapx

  • Description modified (diff)

comment:4 Changed 2 years ago by sebastian

  • Component changed from Adblock-Plus-for-Firefox to Platform

comment:5 Changed 23 months ago by mapx

  • Cc kzar hfiguiere added

comment:6 Changed 23 months ago by mapx

Trying to close (clicking "Cancel" ) the empty window, I get (in the console)

Scripts may not close windows that were not opened by script. composer.js:64:2

Clicking the window "x" I get in the console (but however the window is then closed clicking twice):

Error: port.onDisconnect.hasListeners is not a function  undefined
Error: Could not establish connection. Receiving end does not exist.  undefined



comment:7 Changed 23 months ago by trev

I can reproduce this issue in Nightly (58.0a1 2017-10-26 on Linux) but not on Firefox 56. It's not actually an empty window however, resizing it makes the content appear - seems to be a Firefox rendering bug. Also, clicking the Cancel button works correctly here.

comment:8 Changed 23 months ago by trev

There is a browser error being reported which is likely the cause:

TypeError: invalid 'in' operand browser tabbrowser.xml:2437:1

comment:9 Changed 23 months ago by mapx

as I said it happens in FF 57. No text in the window, "cancel" not working.

comment:10 Changed 23 months ago by trev

  • Description modified (diff)
  • Owner set to trev
  • Priority changed from Unknown to P1
  • Ready set
Note: See TracTickets for help on using tickets.