Opened 2 years ago

Closed 2 years ago

#5818 closed change (fixed)

Update build settings based on Xcode 9 recommendations

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: mario, tiago, ashephard, CraftyDeano Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29562655/

Description

Background

The following warning appears in Xcode 9.

Build Settings 
Project 'AdblockPlusSafari' - Enable Recommended Warnings 
This will enable the following recommended compiler warnings: 
* Block Capture of Autoreleasing
* Implicit Non-Literal Null Conversions
* Implicit Objective-C Literal Conversions
* Range-based For Loops
* Strict Prototypes
* Suspicious Commas

What to change

Update the build settings to the recommended values.

Change History (2)

comment:1 Changed 2 years ago by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.