Opened 2 years ago

Closed 2 years ago

#5824 closed change (fixed)

Refactor CustomSelect on help.eyeo.com

Reported by: ire Assignee: ire
Priority: Unknown Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29564555/

Description

Background

  • We added a language selector to help.eyeo.com
  • We are extending this custom select element to be used as a dropdown for the browser selector (see codereview)
  • The custom select functionality needs to be more extendable

What to change

Refactor CustomSelect

Change History (3)

comment:1 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5824 - Refactor CustomSelect on help.eyeo.com

comment:3 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.