Opened 17 months ago

Closed 6 weeks ago

#5828 closed defect (fixed)

[CMS] Additional paths require `settings.ini`

Reported by: kvas Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By: #5336
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29972568/

Description

Environment

Linux or MacOS, CMS with additional paths feature from #5336. The source of any website.

How to reproduce

  1. Add an additional path to the website via additional-paths key in [paths] section of settings.ini. The additional path directory should not contain settings.ini.
  2. Run a test server or generation for the website.

Observed behaviour

The CMS throws an IOError for settings.ini in the additional path.

Expected behaviour

The files contained within the directory of additional path can be used even if there's no settings.ini in it.

Change History (6)

comment:1 Changed 17 months ago by juliandoucette

LGTM

comment:2 Changed 16 months ago by kvas

  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from Additional paths require `settings.ini` to [CMS] Additional paths require `settings.ini`

comment:3 Changed 9 months ago by rhowell

  • Owner set to rhowell

comment:4 Changed 7 weeks ago by rhowell

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 6 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 5828 - Additional paths require settings.ini

comment:6 Changed 6 weeks ago by rhowell

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.