Opened 19 months ago

Last modified 19 months ago

#5833 new defect

Opening comments section on youtube brings up footer instead

Reported by: traynard Assignee:
Priority: Unknown Milestone:
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABB 2.0
iOS

How to reproduce

  1. in ABB 2.0 navigate to youtube.com
  2. tap to open any video
  3. scroll down to the bottom of the page (below related videos)
  4. tap on "Comments" to view comments on the video

Observed behaviour

Comment section does not expand, instead the ABB footer is opened

Expected behaviour

comments section should expand as expected.

Attachments (1)

ScreenRecording_ABBiOS.mp4 (2.9 MB) - added by traynard 19 months ago.
Video recording of issue

Download all attachments as: .zip

Change History (5)

Changed 19 months ago by traynard

Video recording of issue

comment:1 Changed 19 months ago by mario

@traynard, could this be related to #3932? It brings up the bottom bar when the bottom edge of the screen is tapped. Safari should behave the same IIRC. Are you able to tap the "expand" link as soon as the bottom bar is visible?

If this is indeed caused by #3932, we'll need to find a solution for those edge cases. E.g. when tapping the bottom edge of the display, only bring up the bottom bar if the tap can't be propagated to a tapable element within that area.

comment:2 Changed 19 months ago by traynard

@mario It definitely seems to be related to #3932.

in Safari: When you tap on the "Comments" section on youtube (to stick to the example), the bottom bar does become visible. However, it pushes up the content so the "Comments" section is resting above the bar and allows users to interact with it.

in ABB: When you tap on the "Comments" section on youtube, the bottom bar becomes visible and overlaps the comments section. This disables users from interacting with it in any way. If you attempt to scroll up to access the comments section, the bottom bar disappears and the cycle begins again.

comment:3 Changed 19 months ago by mario

@traynard, Ahh, that makes sense! Thanks for comparing both. I think we should adopt Safari's behavior, as it mitigates the problem in a nice, straight-forward way. I'll rewrite the ticket slightly to reflect this.

comment:4 Changed 19 months ago by traynard

@mario - Yeah, i agree. Sounds good, thanks!

Note: See TracTickets for help on using tickets.