Opened 2 years ago

Closed 2 years ago

#5836 closed change (fixed)

Update buildtools dependency and adapt for locale changes

Reported by: sebastian Assignee: sebastian
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #5751, #5763
Blocking: #5837 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29565802

Description (last modified by sebastian)

Background

With #5763, all projects need to use the same language codes (i.e. no region suffix except for en-*, es-*, pt-* and zh-*), while previously some projects used Chrome-specifc locales, and others (including adblockplusui) used Firefox-specifc locales.

With #5751, language codes in names of the locale/* sub-directories must always use underscores, while previously some projects (including adblockplusui) could use dashes.

This dependency update also fixes compatibility with the Crowdin API (#4836, #5777 and #5815), which currently is broken.

Any other change in buildtools since the last dependency update doesn't effect adblockplusui.

What to change

  • Update the dependencies file to refer to revisions of buildtoolsafter #5763 and #5751 landed.
  • Remove the obsolete options name_format, file_format and target_platforms from metadata.generic.
  • Change default_locale (from en-US) to en_US.
  • Rename the locale/* sub-directories as described above.

Change History (8)

comment:1 Changed 2 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by sebastian

  • Blocking 5837 added

comment:3 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 2 years ago by kzar

  • Description modified (diff)

I've added some quick integration notes for the webpack changes as Sebastian requested in IRC, since I have to leave now that's all I have time for but I can add more information later if necessary.

comment:5 Changed 2 years ago by kzar

  • Description modified (diff)

Sorry in the rush I updated the wrong ticket! Ignore the above comment.

comment:6 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:7 Changed 2 years ago by abpbot

comment:8 Changed 2 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.