Opened 2 years ago

Closed 2 years ago

#5850 closed defect (fixed)

Social media profile links don't open on Help tab

Reported by: arthur Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: saroyanm, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29573041/

Description

Environment

Nightly 58.0a1 20171009220104
ABP 2.99.0.1877beta

How to reproduce

  1. Go into the options of ABP
  2. Click on "Help"
  3. Click on the Twitter icon

Observed behaviour

Nightly shows a CSP error page.

Expected behaviour

Nightly should open the Twitter profile page of ABP.

Notes

The Facebook and Google Plus pages also don't open for me but there is no error page.

Change History (8)

comment:1 Changed 2 years ago by arthur

  • Platform changed from Firefox to Unknown / Cross platform

comment:2 Changed 2 years ago by arthur

  • Cc greiner added

comment:3 Changed 2 years ago by saroyanm

  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed 2 years ago by saroyanm

We are loading new options page in the Iframe, so we will need to specify target attribute for the links either "_top" or "_blank".

comment:5 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:6 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5850 - Fixed broken Social media links

comment:8 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.