Opened 14 months ago

Closed 3 months ago

Last modified 8 weeks ago

#5851 closed defect (fixed)

Layout shifts after opening Custom subscription popup in new options page

Reported by: wspee Assignee: greiner
Priority: P4 Milestone:
Module: User-Interface Keywords:
Cc: saroyanm, greiner Blocked By:
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/105

Description (last modified by greiner)

See also ui#190.

Environment

Firefox 57.0b6
adblockpluschrome 5f567fd2a52a gecko-webext devenv

How to reproduce

  1. Open Options Page
  2. Open Advanced Tab
  3. Observe distance between Filter lists table and buttons below
  4. Open the Custom subscription popup via the button labelled + ADD A NEW FILTER LIST

Observed behaviour

The buttons below the Filter lists table are shifted down see:


Expected behaviour

The distance between the Filter lists table and the buttons below should remain the same.

Attachments (3)

firefox_custom_filterlist_1.png (88.2 KB) - added by wspee 14 months ago.
firefox_custom_filterlist_2.png (70.8 KB) - added by wspee 14 months ago.
firefox_custom_filterlist_3.png (83.4 KB) - added by wspee 14 months ago.

Download all attachments as: .zip

Change History (11)

Changed 14 months ago by wspee

Changed 14 months ago by wspee

Changed 14 months ago by wspee

comment:1 Changed 14 months ago by wspee

  • Cc saroyanm greiner added
  • Description modified (diff)

comment:2 Changed 14 months ago by saroyanm

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 3 months ago by greiner

  • Description modified (diff)

Added link to corresponding GitLab issue.

comment:4 Changed 3 months ago by greiner

  • Owner set to greiner

comment:5 Changed 3 months ago by greiner

  • Blocking 6892 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 3 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 3 months ago by abpbot

comment:8 Changed 8 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Buttons are not shifted down by the dialog.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.