Opened on 10/10/2017 at 09:57:19 AM

Closed on 09/07/2018 at 01:08:40 PM

Last modified on 10/18/2018 at 12:22:35 PM

#5851 closed defect (fixed)

Layout shifts after opening Custom subscription popup in new options page

Reported by: wspee Assignee: greiner
Priority: P4 Milestone:
Module: User-Interface Keywords:
Cc: saroyanm, greiner Blocked By:
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by greiner)

See also ui#190.


Firefox 57.0b6
adblockpluschrome 5f567fd2a52a gecko-webext devenv

How to reproduce

  1. Open Options Page
  2. Open Advanced Tab
  3. Observe distance between Filter lists table and buttons below
  4. Open the Custom subscription popup via the button labelled + ADD A NEW FILTER LIST

Observed behaviour

The buttons below the Filter lists table are shifted down see:

Expected behaviour

The distance between the Filter lists table and the buttons below should remain the same.

Attachments (3)

firefox_custom_filterlist_1.png (88.2 KB) - added by wspee on 10/10/2017 at 09:57:39 AM.
firefox_custom_filterlist_2.png (70.8 KB) - added by wspee on 10/10/2017 at 09:57:46 AM.
firefox_custom_filterlist_3.png (83.4 KB) - added by wspee on 10/10/2017 at 09:57:53 AM.

Download all attachments as: .zip

Change History (11)

Changed on 10/10/2017 at 09:57:39 AM by wspee

Changed on 10/10/2017 at 09:57:46 AM by wspee

Changed on 10/10/2017 at 09:57:53 AM by wspee

comment:1 Changed on 10/10/2017 at 10:00:08 AM by wspee

  • Cc saroyanm greiner added
  • Description modified (diff)

comment:2 Changed on 10/10/2017 at 01:09:48 PM by saroyanm

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed on 09/06/2018 at 05:09:38 PM by greiner

  • Description modified (diff)

Added link to corresponding GitLab issue.

comment:4 Changed on 09/06/2018 at 05:21:46 PM by greiner

  • Owner set to greiner

comment:5 Changed on 09/06/2018 at 05:26:51 PM by greiner

  • Blocking 6892 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 09/07/2018 at 01:08:40 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 09/13/2018 at 10:30:18 AM by abpbot

comment:8 Changed on 10/18/2018 at 12:22:35 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Buttons are not shifted down by the dialog.

Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.