Opened 2 years ago

Closed 2 years ago

#5852 closed change (fixed)

Change hover/focus/active colour for accordion menu on help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette, wspee, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29602557/

Description (last modified by ire)

Background

For the accordion menu headers, the current non-active background-color is #ECECEC. The current hover/focus/active colour is #AEAEAE. The latter colour is too dark.

What to change

Use #C4C4C4 as the background-color on hover/focus/active colour

Attachments (2)

Inactive.png (72.4 KB) - added by ire 2 years ago.
Inactive State
Active:Hover:Focus.png (74.3 KB) - added by ire 2 years ago.
Active/Hover/Focus State

Download all attachments as: .zip

Change History (11)

Changed 2 years ago by ire

Inactive State

Changed 2 years ago by ire

Active/Hover/Focus State

comment:1 Changed 2 years ago by ire

  • Cc jeen added

comment:2 Changed 2 years ago by ire

@Jeen could you please advise on what colour the hover/active/focus state for the accordion headers should be? I've attached images with what it currently looks like and the hex colours are in the description

comment:3 Changed 2 years ago by ire

  • Milestone set to help.eyeo.com 1.0.0
  • Priority changed from Unknown to P3

comment:4 follow-up: Changed 2 years ago by jeen

Hi Ire- let's use #C4C4C4 - it has a better contrast but is still distinguishable from the non-active state.

comment:5 in reply to: ↑ 4 Changed 2 years ago by ire

  • Description modified (diff)

Replying to jeen:

Hi Ire- let's use #C4C4C4 - it has a better contrast but is still distinguishable from the non-active state.

Thanks!

comment:6 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 2 years ago by ire

  • Owner set to ire

comment:9 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.