Changes between Initial Version and Version 1 of Ticket #5856, comment 2


Ignore:
Timestamp:
10/11/2017 11:16:08 PM (2 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5856, comment 2

    initial v1  
    1 Before I knew that the messed up order in `package-lock.json` was caused by a difference in the npm version, I went ahead [https://hg.adblockplus.org/buildtools/rev/2ee884010cf5 fixing the order] (for newer versions of npm). However, now I noticed that this might not have been the best idea, as the build server might still rely on the old npm version. Furthermore, I found another issue with the webpack integration in `buildtools`. So I backed out the whole change for now, see ticket:5535#comment39. 
     1Before I knew that the messed up order in `package-lock.json` was caused by a difference in the npm version, I went ahead [https://hg.adblockplus.org/buildtools/rev/2ee884010cf5 fixing the order] (for newer versions of npm). However, now I noticed that this might not have been the best idea, as the build server might still rely on the old npm version. Furthermore, I found another issue with the webpack integration in `buildtools`. So I backed out the whole change for now, see ticket:5535#comment:39. 
    22 
    33This issue can probably be closed as a duplicate of #5535, now, where we can address this before landing the webpack integration again.