Changes between Initial Version and Version 1 of Ticket #5856


Ignore:
Timestamp:
10/11/2017 10:07:01 PM (2 years ago)
Author:
sebastian
Comment:

I have a hunch that trev and/or kzar wouldn't be happy with this change. But FWIW, I wasn't happy with adding package-lock.json to the repository in the first place, and given the mess it is causing now, I'd second removing it.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5856 – Description

    initial v1  
    11=== Background === 
    2 `npm install` generates a package-lock.json, which was originally supposed the guarantee an equal environment wherever `npm install` was run. Unfortunately, it seems like (confirmed by Sebastian / Tristan) an upgrade of `npm` itself could result in a reordering of the package-lock.json, which again results in a cascading need to update nested dependencies. 
     2`npm install` generates a package-lock.json, which was originally supposed the guarantee an equal environment wherever `npm install` was run. Unfortunately, it seems like (confirmed by Sebastian / Tristan) an upgrade of `npm` itself could result in a reordering of the package-lock.json, which causes `hg update` (called by `ensure_depdencies.py`) to fail due to local modification. 
    33 
    44=== What to change === 
    5 * Let the repositories ignore any by `ensure_dependencies.py` / `npm install` generated package-lock.json 
     5* Remove `package-lock.json` from the `buildtools` repository. 
     6* List `package-lock.json` in `.hgignore` and `.gitignore`.