Opened on 10/12/2017 at 03:37:23 PM

Closed on 10/13/2017 at 08:56:16 AM

#5860 closed defect (fixed)

options page is broken in test enviroment

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



All browsers

How to reproduce

  1. Clone adblockplusui repository
  2. Run test enviroment
  3. Open desktop-options.html
  4. Observe

Observed behaviour

The strings are not loaded and current errors are thrown:

common.js:146 GET 404 (File not found)
common.js:146 GET 404 (File not found)

Expected behaviour

Strings are loaded, no errors are thrown

Attachments (0)

Change History (5)

comment:1 Changed on 10/12/2017 at 03:38:01 PM by saroyanm

  • Owner set to saroyanm

Seems like it's caused by latest change in #5836

comment:2 Changed on 10/12/2017 at 05:55:36 PM by sebastian

Right, the code in ext/common.js implementing chrome.i18n needs to be changed, to use underscores instead of dashes. I could submit a patch, but I assume you are already on it, as you assigned the issue to yourself.

Last edited on 10/12/2017 at 05:58:10 PM by sebastian

comment:3 Changed on 10/12/2017 at 06:23:20 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Sorry, I forgot to add the review here. I Will address your comments in the review later today.

comment:4 Changed on 10/13/2017 at 08:55:46 AM by abpbot

A commit referencing this issue has landed:
Issue 5860 - Fixed broken options page in the test enviroment

comment:5 Changed on 10/13/2017 at 08:56:16 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.