Opened 16 months ago
Last modified 16 months ago
#5861 new defect
Fix missing locale errors in the options page test enviroment
Reported by: | saroyanm | Assignee: | |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | greiner | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by saroyanm)
Environment
All browsers
How to reproduce
- Clone adblockplusui repository
- Run test enviroment
- Open desktop-options.html
- Observe
Observed behaviour
The strings are not loaded and current errors are thrown:
common.js:146 GET http://127.0.0.1:5000/locale/en/common.json 404 (File not found) common.js:146 GET http://127.0.0.1:5000/locale/en/desktop-options.json 404 (File not found)
Expected behaviour
- Strings are loaded, no errors are thrown
- Ideally we would like to also throw error when requested string is not available (ex. Unknown localization message $msgId$).
Change History (2)
comment:1 Changed 16 months ago by saroyanm
comment:2 Changed 16 months ago by saroyanm
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
The issue here seems to be xhr error handling, while it seems like error handling here is tricky maybe we can use fetch API.
I haven't make it part of #5860 intentionally as the priority of this issue is lower than the other one.