Opened on 10/13/2017 at 08:58:03 AM

Closed on 09/09/2019 at 03:25:28 PM

#5861 closed defect (worksforme)

Fix missing locale errors in the options page test enviroment

Reported by: saroyanm Assignee:
Priority: P4 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)


All browsers

How to reproduce

  1. Clone adblockplusui repository
  2. Run test enviroment
  3. Open desktop-options.html
  4. Observe

Observed behaviour

The strings are not loaded and current errors are thrown:

common.js:146 GET 404 (File not found)
common.js:146 GET 404 (File not found)

Expected behaviour

  • Strings are loaded, no errors are thrown
  • Ideally we would like to also throw error when requested string is not available (ex. Unknown localization message $msgId$).

Attachments (0)

Change History (3)

comment:1 Changed on 10/13/2017 at 09:03:25 AM by saroyanm

The issue here seems to be xhr error handling, while it seems like error handling here is tricky maybe we can use fetch API.

I haven't make it part of #5860 intentionally as the priority of this issue is lower than the other one.

comment:2 Changed on 10/24/2017 at 05:51:25 PM by saroyanm

  • Description modified (diff)

comment:3 Changed on 09/09/2019 at 03:25:28 PM by greiner

  • Resolution set to worksforme
  • Status changed from new to closed

Closing this ticket because we have since added translation file linting to ensure those files are valid (see ui#82). Furthermore, any errors relating to missing translation files are either expected (i.e. we don't have translations for a given file yet) or an actual error (e.g. we forgot to remove the reference to a translation file that no longer exists).

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.