Opened 2 years ago

Closed 20 months ago

Last modified 20 months ago

#5870 closed change (fixed)

[emscripten] Implement the new ElemHideEmulation filter type

Reported by: hfiguiere Assignee: hfiguiere
Priority: P3 Milestone:
Module: Core Keywords:
Cc: kzar, greiner, arthur, sebastian, sergz Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29595633/

Description (last modified by hfiguiere)

Background

Issue #5287 implement a new type of filter #?# in C++

What to change

  • Support parsing #?# filters and create ElemHideEmulation filters from that.
  • Convert the old syntax of [-abp-properties=] to the new one.
  • Ensure the content script is up to date.

Change History (10)

comment:1 Changed 2 years ago by hfiguiere

  • Description modified (diff)

comment:2 Changed 2 years ago by hfiguiere

  • Component changed from Unknown to Core

comment:3 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed 2 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 21 months ago by sergz

  • Cc kzar greiner arthur sebastian added
  • Priority changed from Unknown to P3

I wonder how long we should actually support the old syntax and whether it's still used somewhere.
@Arthur, could you please share your opinion?

Please feel free to move the discussion somewhere else, in particular if it requires some additional actions.

comment:6 follow-up: Changed 21 months ago by arthur

@sergz
Could you file a Hub ticket for that? Thanks!

comment:7 in reply to: ↑ 6 Changed 21 months ago by sergz

  • Cc sergz added

Replying to arthur:

@sergz
Could you file a Hub ticket for that? Thanks!

Please check #7571 in Hub.

comment:8 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 5870 - Implement the new ElemHideEmulation filter type

comment:9 Changed 20 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 20 months ago by hfiguiere

Merging the content script is issue #6429

Note: See TracTickets for help on using tickets.