Opened 12 months ago

Closed 10 months ago

Last modified 7 months ago

#5873 closed change (fixed)

Show information about bundled filter list in the Language Dialog

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: options-page
Cc: wspee, jeen, greiner, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29655630/

Description (last modified by saroyanm)

Background

We currently are only showing the description in the Dialog, though ideally we would like to communicate to the user about bundled Easylist for the language that have one.

What to change

  • (Ideally) add "+ English" to the bundled filter list.
  • Add full filter list title in the grey brackets as specified

Hints for testers

This implementation affects how the data in lists and tables are being displayed in:

  • General tab
    • PRIVACY & SECURITY section options lists
    • LANGUAGE section (Including "Change" dialog and "Add language dialog") list
  • Whitelisted websites Tab
    • list of whitelisted website websites
  • Advanced tab
    • CUSTOMIZE ON-PAGE ACTIONS section options lists
    • FILTER LISTS Table FILTER LISTS column

Change History (8)

comment:1 Changed 12 months ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 10 months ago by saroyanm

  • Description modified (diff)

comment:3 Changed 10 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 5873 - Show original subscription title in languages table

comment:5 Changed 10 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 10 months ago by saroyanm

  • Cc Ross added
  • Description modified (diff)

Updated hints for testers as this might go to the next release.

comment:7 Changed 10 months ago by saroyanm

  • Description modified (diff)

comment:8 Changed 7 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

ABP 3.0.2.1998
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Note: See TracTickets for help on using tickets.